Sepolia prep: add batch + rollup interval CLI options #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherview
reviewed
Sep 18, 2023
go/node/cmd/main.go
Outdated
Comment on lines
14
to
15
| batchInterval, _ := time.ParseDuration(cliConfig.batchInterval) | ||
| rollupInterval, _ := time.ParseDuration(cliConfig.rollupInterval) |
There was a problem hiding this comment.
What if the node validated the time parsing and this mechanism only took strings and simple types ?
otherview
reviewed
Sep 18, 2023
go/node/cmd/cli.go
Outdated
| @@ -100,6 +105,16 @@ func ParseConfigCLI() *NodeConfigCLI { | |||
| cfg.isDebugNamespaceEnabled = *isDebugNamespaceEnabled | |||
| cfg.logLevel = *logLevel | |||
| cfg.isInboundP2PDisabled = *isInboundP2PDisabled | |||
| cfg.batchInterval = *batchInterval | |||
| if _, err := time.ParseDuration(cfg.batchInterval); err != nil { | |||
There was a problem hiding this comment.
What if the node validated the time parsing and this mechanism only took strings and simple types ?
otherview
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We want to configure slower rollup rate for sepolia-testnet
What changes were made as part of this PR
Wire through CLI options for the docker node starter to set batch/rollup intervals.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks